[Messenger] fixed RabbitMQ arguments not passed as integer values

[thePanz]

Q	A
Branch?	4.2
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#29044
License	MIT

RabbitMQ expects some arguments to be passed as integer values.
Make sure to cast those after parsing the DSN

\cc @thomaskonrad

[ro0NL]

you could do

foreach (array('x-max-..', ...) as $key) {
   if (isset($queueOptions['arguments'][$key]) { ... }
}

and save a few lines. Also im wondering if it's better to add private function getArguments() and normalize when needed (i.e. setArguments(getArguments())

[thePanz]

I refactored that part. I added a constant keeping all the arguments that should be an integer, and later iterating over that. wdyt?

[alquerci]

This patch is a good entry point to find solution of the bug.

But it left to provide a scale-able solution for arguments schema.

Status: Needs Work

[alquerci]

This patch is a good entry point to find solution of the bug.

But it left to provide a scale-able solution for arguments schema.

Status: Needs Work

[alquerci]

@thePanz Changes done from last review pass is good except for one where I have a question.

Also, is it possible to have tests for all arguments keys and for edge cases like when an queue argument value is null?

Status: Needs Review

[alquerci]

@thePanz Changes done from last review pass is good except for one where I have a question.

Also, is it possible to have tests for all arguments keys and for edge cases like when an queue argument value is null?

Status: Needs Review

[thePanz]

@alquerci added handling of null and not-integer values, maybe some more tests should be added?

[alquerci]

@thePanz For tests I think it could be enough.

I have a doubt about how to handle null, because it could mean that the value is not set. Then, in that case removing the key instead of throwing an exception will do the stuff.

@ro0NL, what do you think?

[alquerci]

@thePanz For tests I think it could be enough.

I have a doubt about how to handle null, because it could mean that the value is not set. Then, in that case removing the key instead of throwing an exception will do the stuff.

@ro0NL, what do you think?

[alquerci]

@thePanz Look at fabbot.io review.

[alquerci]

@thePanz Look at fabbot.io review.

[thePanz]

@alquerci is there any other change to be done? :)
Still, I don't know why the @carsonbot added the needs work label 🤔

[alquerci]

@thePanz

Still, I don't know why the @carsonbot added the needs work label 🤔

It was triggered by my last review pass #29532 (review)

---

Now the patch looks good except for the doubt I have:

I have a doubt about how to handle null, because it could mean that the value is not set. Then, in that case removing the key instead of throwing an exception will do the stuff.

[thePanz]

Any updates @alquerci @ro0NL @Toflar ?

[Toflar]

Looks good to me.

[alquerci]

👌

[nicolas-grekas]

Thank you @thePanz.