New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] OutputFormatter: move strtolower to createStyleFromString #29619

Merged
merged 1 commit into from Dec 17, 2018

Conversation

Projects
None yet
5 participants
@ogizanagi
Copy link
Member

ogizanagi commented Dec 15, 2018

Q A
Branch? 3.4
Bug fix? not really
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

While playing with the href feature that'll be available in 4.3,
I spotted href value is lowercased. Which I guess could be an issue on case-sensitive filesystems.
This changes nothing for the current branch, but will allow when merging
to upper branches to fix the behavior described above, hence keep original case.

[Console] OutputFormatter: move strtolower to createStyleFromString
While playing with the href feature that'll be available in 4.3,
I spotted href value is lowercased. Which I guess could be an issue
on case-sensitive filesystems.
This changes nothing for the current branch, but will allow when merging
to upper branches to fix the behavior described above, hence keep original case.
@ostrolucky
Copy link
Contributor

ostrolucky left a comment

good find!

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Dec 17, 2018

Thank you @ogizanagi.

@nicolas-grekas nicolas-grekas merged commit 8e2bd35 into symfony:3.4 Dec 17, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Dec 17, 2018

bug #29619 [Console] OutputFormatter: move strtolower to createStyleF…
…romString (ogizanagi)

This PR was merged into the 3.4 branch.

Discussion
----------

[Console] OutputFormatter: move strtolower to createStyleFromString

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | not really
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

While playing with the href feature that'll be available in 4.3,
I spotted href value [is lowercased](#29620). Which I guess could be an issue on case-sensitive filesystems.
This changes nothing for the current branch, but will allow when merging
to upper branches to fix the behavior described above, hence keep original case.

Commits
-------

8e2bd35 [Console] OutputFormatter: move strtolower to createStyleFromString

@ogizanagi ogizanagi deleted the ogizanagi:console/output_formatter/move_strtolower branch Dec 17, 2018

symfony-splitter pushed a commit to symfony/console that referenced this pull request Dec 17, 2018

minor #29620 [Console] Test href case conservation (ogizanagi)
This PR was merged into the 4.3-dev branch.

Discussion
----------

[Console] Test href case conservation

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | no    <!-- please add some, will be required by reviewers -->
| Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Expecting this test to fail until symfony/symfony#29619 is merged up.

Commits
-------

2b55d1504e [Console] Test href case conservation

nicolas-grekas added a commit that referenced this pull request Dec 17, 2018

minor #29620 [Console] Test href case conservation (ogizanagi)
This PR was merged into the 4.3-dev branch.

Discussion
----------

[Console] Test href case conservation

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | no    <!-- please add some, will be required by reviewers -->
| Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Expecting this test to fail until #29619 is merged up.

Commits
-------

2b55d15 [Console] Test href case conservation

This was referenced Jan 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment