New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Routing] fix trailing slash redirections involving a trailing var #29626

Merged
merged 1 commit into from Dec 17, 2018

Conversation

Projects
None yet
2 participants
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Dec 17, 2018

Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29553
License MIT
Doc PR -

The code in PhpMatcherDumper is terrible, but the good news is that 4.2 is much better already.
The change in UrlMatcher is much more readable and implements the same fixed logic.
The new test case is in UrlMatcherTest.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:route-fix branch from 33dcff9 to 6433f8a Dec 17, 2018

@nicolas-grekas nicolas-grekas merged commit 6433f8a into symfony:4.1 Dec 17, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Dec 17, 2018

bug #29626 [Routing] fix trailing slash redirections involving a trai…
…ling var (nicolas-grekas)

This PR was merged into the 4.1 branch.

Discussion
----------

[Routing] fix trailing slash redirections involving a trailing var

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29553
| License       | MIT
| Doc PR        | -

The code in `PhpMatcherDumper` is terrible, but the good news is that 4.2 is much better already.
The change in `UrlMatcher` is much more readable and implements the same fixed logic.
The new test case is in `UrlMatcherTest`.

Commits
-------

6433f8a [Routing] fix trailing slash redirections involving a trailing var

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:route-fix branch Dec 17, 2018

This was referenced Jan 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment