New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Yaml] detect circular references #29639

Merged
merged 1 commit into from Dec 19, 2018

Conversation

Projects
None yet
5 participants
@xabbuh
Copy link
Member

xabbuh commented Dec 18, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29462
License MIT
Doc PR

@xabbuh xabbuh force-pushed the xabbuh:issue-29462 branch from bfc4111 to b7487f4 Dec 18, 2018

@stof

stof approved these changes Dec 18, 2018

@azjezz

azjezz approved these changes Dec 19, 2018

@nicolas-grekas
Copy link
Member

nicolas-grekas left a comment

Is anyone really using these dark yaml syntaxes?

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Dec 19, 2018

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit b7487f4 into symfony:3.4 Dec 19, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Dec 19, 2018

bug #29639 [Yaml] detect circular references (xabbuh)
This PR was merged into the 3.4 branch.

Discussion
----------

[Yaml] detect circular references

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29462
| License       | MIT
| Doc PR        |

Commits
-------

b7487f4 [Yaml] detect circular references

@xabbuh xabbuh deleted the xabbuh:issue-29462 branch Dec 19, 2018

This was referenced Jan 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment