Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] NotBlank: add a new option to allow null values #29641

Merged
merged 1 commit into from Jan 29, 2019

Conversation

Projects
None yet
8 participants
@dunglas
Copy link
Member

dunglas commented Dec 18, 2018

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27876
License MIT
Doc PR todo

This PR adds a new option to the @NotBlank constraint to allow null values. As described in #27876, this is particularly useful when creating web APIs.

@ro0NL

ro0NL approved these changes Dec 18, 2018

@nicolas-grekas nicolas-grekas added this to the next milestone Dec 19, 2018

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Jan 27, 2019

ping @dunglas

@dunglas dunglas force-pushed the dunglas:notblank_allow_null branch from aea586d to 5856f27 Jan 27, 2019

@dunglas

This comment has been minimized.

Copy link
Member Author

dunglas commented Jan 27, 2019

Should be ready now

@xabbuh

xabbuh approved these changes Jan 28, 2019

Copy link
Member

xabbuh left a comment

Can you please also add an entry to the changelog?

@fabpot

fabpot approved these changes Jan 29, 2019

@dunglas dunglas force-pushed the dunglas:notblank_allow_null branch from 913261c to 9b72462 Jan 29, 2019

@fabpot fabpot force-pushed the dunglas:notblank_allow_null branch from 9b72462 to 484d22a Jan 29, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 29, 2019

Thank you @dunglas.

@fabpot fabpot merged commit 484d22a into symfony:master Jan 29, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jan 29, 2019

feature #29641 [Validator] NotBlank: add a new option to allow null v…
…alues (dunglas)

This PR was squashed before being merged into the 4.3-dev branch (closes #29641).

Discussion
----------

[Validator] NotBlank: add a new option to allow null values

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #27876
| License       | MIT
| Doc PR        | todo

This PR adds a new option to the `@notblank` constraint to allow null values. As described in #27876, this is particularly useful when creating web APIs.

Commits
-------

484d22a [Validator] NotBlank: add a new option to allow null values
@javiereguiluz

This comment has been minimized.

Copy link
Member

javiereguiluz commented Feb 1, 2019

I've created symfony/symfony-docs#10954 to document this new feature. @dunglas please always remember to create at least an issue in Symfony Docs to not forget about documenting new features. Thanks!

@dunglas

This comment has been minimized.

Copy link
Member Author

dunglas commented Feb 1, 2019

Sorry about that @javiereguiluz.

@dunglas dunglas deleted the dunglas:notblank_allow_null branch Feb 1, 2019

javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Feb 1, 2019

minor #10954 Document the allowNull option for NotBlank constraint (j…
…aviereguiluz)

This PR was merged into the master branch.

Discussion
----------

Document the allowNull option for NotBlank constraint

This documents symfony/symfony#29641

Commits
-------

ab2c4f1 Document the allowNull option for NotBlank constraint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.