New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cache] fix bad optim #29644

Merged
merged 1 commit into from Dec 19, 2018

Conversation

Projects
None yet
5 participants
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Dec 18, 2018

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29643
License MIT
Doc PR -
@seclu

This comment has been minimized.

Copy link

seclu commented Dec 18, 2018

@nicolas-grekas out of curiosity, could you provide a description why it fixes the thing?

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Dec 18, 2018

@seclu see what @strider2038 provided in the linked issue #29643.

$e = new \Exception();
$this->includeHandler = function () use ($e) { throw $e; };
$this->includeHandler = function ($type, $msg, $file, $line) {

This comment has been minimized.

@theofidry

theofidry Dec 18, 2018

Contributor

shouldn't this be a static function?

This comment has been minimized.

@nicolas-grekas

nicolas-grekas Dec 18, 2018

Member

it would be a public one - better not (and would be slower if that matters)

This comment has been minimized.

@theofidry

theofidry Dec 18, 2018

Contributor

I meant a static anonymous function, i.e just adding static in front of the current function keyword, not moving it to a static method. It doesn't affect the visibility does it?

This comment has been minimized.

@nicolas-grekas

nicolas-grekas Dec 18, 2018

Member

static it is now

@stof

This comment has been minimized.

Copy link
Member

stof commented Dec 18, 2018

@seclu it does not create an exception with its stack trace in the constructor anymore. the stack trace was the one retaining references to other stuff.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:cache-fix branch from 39cffee to b76d4ea Dec 18, 2018

@nicolas-grekas nicolas-grekas merged commit b76d4ea into symfony:4.2 Dec 19, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

nicolas-grekas added a commit that referenced this pull request Dec 19, 2018

bug #29644 [Cache] fix bad optim (nicolas-grekas)
This PR was merged into the 4.2 branch.

Discussion
----------

[Cache] fix bad optim

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29643
| License       | MIT
| Doc PR        | -

Commits
-------

b76d4ea [Cache] fix bad optim

@fabpot fabpot referenced this pull request Jan 6, 2019

Merged

Release v4.2.2 #29803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment