New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console application as container service #29669

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@edefimov
Copy link

edefimov commented Dec 22, 2018

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29325
License MIT

This PR is an implementation of suggested idea in #29325.

@edefimov edefimov force-pushed the edefimov:application-service branch from 55e9edb to bf97fae Dec 22, 2018

@chalasr chalasr added this to the next milestone Dec 22, 2018

@chalasr

This comment has been minimized.

Copy link
Member

chalasr commented Dec 23, 2018

From the fixed ticket:

This feature will also reduce complexity of adding custom helper sets by defining them as services and injecting them into Application service using CompilerPass.

Note that making it a synthetic service forbids injecting anything into it, as well as manipulating its definition in any way (adding e.g. a method call on the application service would not have any effect).

@edefimov edefimov force-pushed the edefimov:application-service branch 3 times, most recently from c1af692 to 980ff6b Dec 24, 2018

@edefimov edefimov force-pushed the edefimov:application-service branch from 980ff6b to aa8be78 Jan 10, 2019

@edefimov edefimov force-pushed the edefimov:application-service branch from aa8be78 to 7e851fc Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment