New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpFoundation] Fix erasing cookies issue #29676

Merged
merged 7 commits into from Jan 1, 2019

Conversation

Projects
None yet
10 participants
@eiannone
Copy link
Contributor

eiannone commented Dec 23, 2018

Q A
Branch? 4.2 (to be switched when merging)
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29675
License MIT

Prevent replacing existing cookies when starting or regenerating session on PHP < 7.3 with 'cookie_samesite' option.
See issue #29675

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Dec 24, 2018

@rpkamp ok for you?
Would it be possible to add a test case?

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone Dec 24, 2018

@nicolas-grekas nicolas-grekas changed the title Fix erasing cookies issue [HttpFoundation] Fix erasing cookies issue Dec 24, 2018

@rpkamp

This comment has been minimized.

Copy link
Contributor

rpkamp commented Dec 24, 2018

LGTM

Although indeed an added test that proves the issue exists (and servers to prevent regressions) would be good 👍

javiereguiluz and others added some commits Dec 28, 2018

minor #29711 Fixed minor typos in an error message (javiereguiluz)
This PR was squashed before being merged into the 4.2 branch (closes #29711).

Discussion
----------

Fixed minor typos in an error message

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

913fdbe Fixed minor typos in an error message
bug #29721 [SecurityBundle] Fix traceable voters (ro0NL)
This PR was squashed before being merged into the 4.2 branch (closes #29721).

Discussion
----------

[SecurityBundle] Fix traceable voters

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? |  no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #29385
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

lets solve the BC break when autowiring individual voters.

Commits
-------

a7df429 [SecurityBundle] Fix traceable voters
bug #29741 [VarExporter] fix exporting array indexes (xabbuh)
This PR was merged into the 4.2 branch.

Discussion
----------

[VarExporter] fix exporting array indexes

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29715
| License       | MIT
| Doc PR        |

Commits
-------

3c936f4 [VarExporter] fix exporting array indexes
@fabpot

fabpot approved these changes Jan 1, 2019

Fix erasing cookies issue
Prevent replacing existing cookies when starting or regenerating session on PHP < 7.3 with 'cookie_samesite' option.
See issue #29675

@fabpot fabpot changed the base branch from master to 4.2 Jan 1, 2019

@fabpot fabpot force-pushed the eiannone:patch-1 branch from 8a7b4ec to b40801a Jan 1, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 1, 2019

Thank you @eiannone.

@fabpot fabpot merged commit b40801a into symfony:4.2 Jan 1, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build cancelled
Details
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jan 1, 2019

bug #29676 [HttpFoundation] Fix erasing cookies issue (eiannone)
This PR was submitted for the master branch but it was merged into the 4.2 branch instead (closes #29676).

Discussion
----------

[HttpFoundation] Fix erasing cookies issue

| Q             | A
| ------------- | ---
| Branch?       | 4.2 (to be switched when merging)
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29675
| License       | MIT

Prevent replacing existing cookies when starting or regenerating session on PHP < 7.3 with 'cookie_samesite' option.
See issue #29675

Commits
-------

b40801a Fix erasing cookies issue

@fabpot fabpot referenced this pull request Jan 6, 2019

Merged

Release v4.2.2 #29803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment