New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] Add new block_prefix option for an easy form theming #29680

Merged
merged 1 commit into from Jan 3, 2019

Conversation

@yceruto
Copy link
Contributor

yceruto commented Dec 25, 2018

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29651
License MIT
Doc PR symfony/symfony-docs#10835
@HeahDude
Copy link
Member

HeahDude left a comment

Many thanks and merry Christmas <3

@yceruto

This comment has been minimized.

Copy link
Contributor

yceruto commented Dec 25, 2018

Thank you @HeahDude for your quick review and merry Christmas!

@vudaltsov
Copy link
Contributor

vudaltsov left a comment

Great idea, love it!

multiple data
placeholder disabled
preferred_choices help
help_attr

This comment has been minimized.

@OskarStark

OskarStark Dec 26, 2018

Contributor

hmpf this table rst layout makes it hard for small and readable diffs, because in this case only one string is changed (added)

@yceruto yceruto force-pushed the yceruto:add_block_prefix_option branch from f0d120f to bd50ac4 Jan 2, 2019

@yceruto

This comment has been minimized.

Copy link
Contributor

yceruto commented Jan 3, 2019

Doc PR created.

(AppVeyor failure is unrelated)

@fabpot

fabpot approved these changes Jan 3, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 3, 2019

Thank you @yceruto.

@fabpot fabpot merged commit bd50ac4 into symfony:master Jan 3, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jan 3, 2019

feature #29680 [Form] Add new block_prefix option for an easy form th…
…eming (yceruto)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Form] Add new block_prefix option for an easy form theming

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29651
| License       | MIT
| Doc PR        | symfony/symfony-docs#10835

Commits
-------

bd50ac4 Add block_prefix option for an easy form theming

@yceruto yceruto deleted the yceruto:add_block_prefix_option branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment