New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] access the container getting it from the kernel #29708

Merged
merged 1 commit into from Jan 2, 2019

Conversation

Projects
None yet
4 participants
@xabbuh
Copy link
Member

xabbuh commented Dec 28, 2018

Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29707
License MIT
Doc PR
@fabpot

fabpot approved these changes Jan 2, 2019

@fabpot fabpot changed the base branch from master to 4.1 Jan 2, 2019

@fabpot fabpot force-pushed the xabbuh:issue-29707 branch from 12200e4 to 68ea3f1 Jan 2, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 2, 2019

Thank you @xabbuh.

@fabpot fabpot merged commit 68ea3f1 into symfony:4.1 Jan 2, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build cancelled
Details
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jan 2, 2019

bug #29708 [FrameworkBundle] access the container getting it from the…
… kernel (xabbuh)

This PR was submitted for the master branch but it was merged into the 4.1 branch instead (closes #29708).

Discussion
----------

[FrameworkBundle] access the container getting it from the kernel

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29707
| License       | MIT
| Doc PR        |

Commits
-------

68ea3f1 access the container getting it from the kernel

@xabbuh xabbuh deleted the xabbuh:issue-29707 branch Jan 2, 2019

This was referenced Jan 6, 2019

symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull request Jan 13, 2019

feature #29840 [FrameworkBundle] pass project dir into the assets ins…
…tall command (xabbuh)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[FrameworkBundle] pass project dir into the assets install command

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | symfony/symfony#29708 (comment)
| License       | MIT
| Doc PR        |

Commits
-------

b373d4206b pass project dir into the assets install command

fabpot added a commit that referenced this pull request Jan 13, 2019

feature #29840 [FrameworkBundle] pass project dir into the assets ins…
…tall command (xabbuh)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[FrameworkBundle] pass project dir into the assets install command

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #29708 (comment)
| License       | MIT
| Doc PR        |

Commits
-------

b373d42 pass project dir into the assets install command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment