New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Event Dispatcher] fixed 29703: TraceableEventDispatcher reset() callStack to null #29714

Merged
merged 1 commit into from Dec 29, 2018

Conversation

Projects
None yet
7 participants
@lievertz
Copy link

lievertz commented Dec 28, 2018

[Event Dispatcher] fixed 29703: TraceableEventDispatcher reset now sets callStack to null with test to dispatch after reset.

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29703
License MIT
Doc PR N/A

[Event Dispatcher] fixed 29703: TraceableEventDispatcher reset now sets callStack to null with test to dispatch after reset. Basically #29411 introduced an issue where calling dispatch after a reset would throw an error because now reset set callStack to array but dispatch expected either SplObjectStorage or null. Now reset sets null. Also added a test to verify dispatch works following a call to reset.

mlievertz
[Event Dispatcher] fixed 29703: TraceableEventDispatcher reset now se…
…ts callStack to null with test to dispatch after reset.
@ro0NL

ro0NL approved these changes Dec 28, 2018

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Dec 28, 2018

@xabbuh

xabbuh approved these changes Dec 28, 2018

@fabpot

fabpot approved these changes Dec 29, 2018

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Dec 29, 2018

Thank you @lievertz.

@fabpot fabpot merged commit 51bcdb8 into symfony:3.4 Dec 29, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Dec 29, 2018

bug #29714 [Event Dispatcher] fixed 29703: TraceableEventDispatcher r…
…eset() callStack to null (mlievertz)

This PR was merged into the 3.4 branch.

Discussion
----------

[Event Dispatcher] fixed 29703: TraceableEventDispatcher reset() callStack to null

[Event Dispatcher] fixed 29703: TraceableEventDispatcher reset now sets callStack to null with test to dispatch after reset.

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #29703    <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A <!-- required for new features -->

[Event Dispatcher] fixed 29703: TraceableEventDispatcher reset now sets callStack to null with test to dispatch after reset. Basically #29411 introduced an issue where calling dispatch after a reset would throw an error because now reset set callStack to array but dispatch expected either SplObjectStorage or null. Now reset sets null. Also added a test to verify dispatch works following a call to reset.

Commits
-------

51bcdb8 [Event Dispatcher] fixed 29703: TraceableEventDispatcher reset now sets callStack to null with test to dispatch after reset.

@lievertz lievertz deleted the lievertz:ticket_29703 branch Dec 31, 2018

This was referenced Jan 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment