New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "minor #28610 [Form] Check for Intl availibility (ro0NL)" #29720

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Projects
None yet
4 participants
@chalasr
Copy link
Member

chalasr commented Dec 28, 2018

Q A
Branch? 4.2
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Intl is an hard dependency for Form, these checks cannot be reached.

Revert "minor #28610 [Form] Check for Intl availibility (ro0NL)"
This reverts commit 15aa25a, reversing
changes made to 3cd411a.
@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Jan 3, 2019

Thank you @chalasr.

@nicolas-grekas nicolas-grekas merged commit 3ac98a6 into symfony:4.2 Jan 3, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jan 3, 2019

minor #29720 Revert "minor #28610 [Form] Check for Intl availibility …
…(ro0NL)" (chalasr)

This PR was merged into the 4.2 branch.

Discussion
----------

Revert "minor #28610 [Form] Check for Intl availibility (ro0NL)"

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Intl is an hard dependency for Form, these checks cannot be reached.

Commits
-------

3ac98a6 Revert "minor #28610 [Form] Check for Intl availibility (ro0NL)"

@chalasr chalasr deleted the chalasr:drop-dead-code branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment