New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecurityBundle] Fix traceable voters #29721

Merged
merged 1 commit into from Jan 1, 2019

Conversation

Projects
None yet
5 participants
@ro0NL
Copy link
Contributor

ro0NL commented Dec 29, 2018

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29385
License MIT
Doc PR symfony/symfony-docs#...

lets solve the BC break when autowiring individual voters.

@ro0NL ro0NL changed the title [SecurityBundle] Fix tracable voters [SecurityBundle] Fix traceable voters Dec 29, 2018

@ro0NL ro0NL force-pushed the ro0NL:voter branch from 63d0a36 to 8dc37ea Dec 29, 2018

@xabbuh

This comment has been minimized.

Copy link
Member

xabbuh commented Dec 29, 2018

Does it make sense to add a test which ensures that the original voter class can be retrieved from the compiled container?

@ro0NL ro0NL force-pushed the ro0NL:voter branch from 8dc37ea to 3b8bce6 Dec 29, 2018

@ro0NL

This comment has been minimized.

Copy link
Contributor

ro0NL commented Dec 29, 2018

updated test to check voters are NOT decorated

@xabbuh

xabbuh approved these changes Dec 29, 2018

@chalasr

chalasr approved these changes Jan 1, 2019

@chalasr chalasr added this to the 4.2 milestone Jan 1, 2019

@chalasr chalasr force-pushed the ro0NL:voter branch from 8deba3e to a7df429 Jan 1, 2019

@chalasr

This comment has been minimized.

Copy link
Member

chalasr commented Jan 1, 2019

Thank you @ro0NL.

@chalasr chalasr merged commit a7df429 into symfony:4.2 Jan 1, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

chalasr added a commit that referenced this pull request Jan 1, 2019

bug #29721 [SecurityBundle] Fix traceable voters (ro0NL)
This PR was squashed before being merged into the 4.2 branch (closes #29721).

Discussion
----------

[SecurityBundle] Fix traceable voters

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? |  no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #29385
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

lets solve the BC break when autowiring individual voters.

Commits
-------

a7df429 [SecurityBundle] Fix traceable voters

@ro0NL ro0NL deleted the ro0NL:voter branch Jan 1, 2019

@fabpot fabpot referenced this pull request Jan 6, 2019

Merged

Release v4.2.2 #29803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment