New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHPUnitBridge] Static access in closure #29724

Open
wants to merge 8 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@greg0ire
Copy link
Contributor

greg0ire commented Dec 29, 2018

Q A
Branch? master for features
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n / a
License MIT
Doc PR n / a

#29718 bumps php to 5.5 . This is what we could simplify if it gets merged, thanks to this "new" PHP feature: https://3v4l.org/sJOWr

EDIT: it was merged, this can be reviewed.

@greg0ire

This comment has been minimized.

Copy link
Contributor

greg0ire commented Dec 29, 2018

Doing many commits for now, in case some of them cannot be merged. Will squash if everything is all good.

@greg0ire greg0ire force-pushed the greg0ire:static_access_in_closure branch 2 times, most recently from 8df51b1 to e90bfef Dec 30, 2018

@greg0ire

This comment has been minimized.

Copy link
Contributor

greg0ire commented Dec 30, 2018

Prepended the commit list with one cs-fix commit (self accessor), apparently the code wasn't even valid before any changes. Got rid of the fabbot commit by dispatching changes to the right commits.

@greg0ire greg0ire force-pushed the greg0ire:static_access_in_closure branch from e90bfef to 5345897 Dec 30, 2018

@greg0ire

This comment has been minimized.

Copy link
Contributor

greg0ire commented Dec 30, 2018

The Travis failure seems unrelated.

@greg0ire greg0ire changed the title Static access in closure [PHPUnitBridge] Static access in closure Dec 30, 2018

@greg0ire greg0ire force-pushed the greg0ire:static_access_in_closure branch from 5345897 to 2584634 Jan 1, 2019

@nicolas-grekas nicolas-grekas added this to the next milestone Jan 3, 2019

@greg0ire greg0ire force-pushed the greg0ire:static_access_in_closure branch 2 times, most recently from 17417bb to b7100b3 Jan 3, 2019

@greg0ire

This comment has been minimized.

Copy link
Contributor

greg0ire commented Jan 3, 2019

The build failures are unrelated, please review again @nicolas-grekas

greg0ire added some commits Dec 29, 2018

@greg0ire greg0ire force-pushed the greg0ire:static_access_in_closure branch 2 times, most recently from 1a12b1c to 79921b3 Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment