New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Intl] handle null date and time types #29738

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Projects
None yet
4 participants
@xabbuh
Copy link
Member

xabbuh commented Dec 31, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29705
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.4 milestone Dec 31, 2018

@ro0NL
Copy link
Contributor

ro0NL left a comment

getDateType + static create() also need a patch

@xabbuh xabbuh force-pushed the xabbuh:issue-29705 branch from 9f78a98 to 6ded31a Jan 3, 2019

@xabbuh

This comment has been minimized.

Copy link
Member

xabbuh commented Jan 3, 2019

@ro0NL I fail to see which change is needed for getDateType().

@ro0NL

ro0NL approved these changes Jan 3, 2019

Copy link
Contributor

ro0NL left a comment

never mind, $dateType cant be null anymore :)

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Jan 3, 2019

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 6ded31a into symfony:3.4 Jan 3, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jan 3, 2019

bug #29738 [Intl] handle null date and time types (xabbuh)
This PR was merged into the 3.4 branch.

Discussion
----------

[Intl] handle null date and time types

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29705
| License       | MIT
| Doc PR        |

Commits
-------

6ded31a [Intl] handle null date and time types

@xabbuh xabbuh deleted the xabbuh:issue-29705 branch Jan 3, 2019

This was referenced Jan 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment