New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCA: minor code tweaks #29745

Merged
merged 1 commit into from Jan 13, 2019

Conversation

@kalessil
Copy link
Contributor

kalessil commented Jan 2, 2019

Q A
Branch? 4.1
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Eliminated a few excessive calls, tweaked query parameters sorting

@lyrixx

lyrixx approved these changes Jan 2, 2019

@nicolas-grekas nicolas-grekas added this to the 4.1 milestone Jan 3, 2019

@xabbuh

xabbuh approved these changes Jan 7, 2019

@chalasr

chalasr approved these changes Jan 7, 2019

@fabpot

fabpot approved these changes Jan 13, 2019

@fabpot fabpot force-pushed the kalessil:4.1 branch from e69ba8d to 8887f76 Jan 13, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 13, 2019

Thank you @kalessil.

@fabpot fabpot merged commit 8887f76 into symfony:4.1 Jan 13, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jan 13, 2019

minor #29745 SCA: minor code tweaks (kalessil)
This PR was squashed before being merged into the 4.1 branch (closes #29745).

Discussion
----------

SCA: minor code tweaks

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Eliminated a few excessive calls, tweaked query parameters sorting

Commits
-------

8887f76 SCA: minor code tweaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment