New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved BIC + IBAN validator for some special cases #29755

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Projects
None yet
5 participants
@javiereguiluz
Copy link
Member

javiereguiluz commented Jan 3, 2019

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

While blogging about Improved Financial Constraints in Symfony 4.3 I found this resource that mentions some exceptions when validating BIC + IBAN: https://wiki.xmldation.com/index.php?title=Support/EPC/IBAN_%26_BIC_relation

I don't know if that resource is fully reliable ... but I checked it in the official "European Banking Resources" website (https://www.ecbs.org/iban/) and most of it matches, so I think we can safely make this change.

@fabpot

fabpot approved these changes Jan 3, 2019

@xabbuh

xabbuh approved these changes Jan 3, 2019

@nicolas-grekas
Copy link
Member

nicolas-grekas left a comment

for 4.2 as a bug fix?

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.2 Jan 3, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Jan 3, 2019

NVM, that's for master :)

@nicolas-grekas nicolas-grekas force-pushed the javiereguiluz:improve_28479 branch from 9910c15 to 88a1696 Jan 3, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Jan 3, 2019

Thank you @javiereguiluz.

@nicolas-grekas nicolas-grekas merged commit 88a1696 into symfony:master Jan 3, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jan 3, 2019

bug #29755 Improved BIC + IBAN validator for some special cases (javi…
…ereguiluz)

This PR was squashed before being merged into the 4.3-dev branch (closes #29755).

Discussion
----------

Improved BIC + IBAN validator for some special cases

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

While blogging about [Improved Financial Constraints in Symfony 4.3](https://symfony.com/blog/new-in-symfony-4-3-improved-financial-constraints) I found this resource that mentions some exceptions when validating BIC + IBAN: https://wiki.xmldation.com/index.php?title=Support/EPC/IBAN_%26_BIC_relation

I don't know if that resource is fully reliable ... but I checked it in the official "European Banking Resources" website (https://www.ecbs.org/iban/) and most of it matches, so I think we can safely make this change.

Commits
-------

88a1696 Improved BIC + IBAN validator for some special cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment