New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHPUnitBridge][TestSuite] Do not risk waiting 100 seconds #29761

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Projects
None yet
5 participants
@greg0ire
Copy link
Contributor

greg0ire commented Jan 3, 2019

Q A
Branch? 4.2
Bug fix? no
New feature? no
BC breaks? no
Deprecations? nofiles -->
Tests pass? yes, a bit more often
Fixed tickets not entirely fixing it
License MIT
Doc PR n/a

It this happens, and it happens, this will make the build quite slow.
Refs #29760

Do not risk waiting 100 seconds
It this happens, and it happens, this will make the build quite slow.
Refs #29760

@nicolas-grekas nicolas-grekas changed the base branch from master to 4.2 Jan 3, 2019

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone Jan 3, 2019

@fabpot

fabpot approved these changes Jan 3, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Jan 3, 2019

Thank you @greg0ire.

@nicolas-grekas nicolas-grekas merged commit 9f45af4 into symfony:4.2 Jan 3, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jan 3, 2019

minor #29761 [PHPUnitBridge][TestSuite] Do not risk waiting 100 secon…
…ds (greg0ire)

This PR was merged into the 4.2 branch.

Discussion
----------

[PHPUnitBridge][TestSuite] Do not risk waiting 100 seconds

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | nofiles -->
| Tests pass?   | yes, a bit more often
| Fixed tickets | not entirely fixing it
| License       | MIT
| Doc PR        | n/a

It this happens, and it happens, this will make the build quite slow.
Refs #29760

Commits
-------

9f45af4 Do not risk waiting 100 seconds

@greg0ire greg0ire deleted the greg0ire:fix-timeout branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment