New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove no longer needed PHP version checks #29776

Merged
merged 1 commit into from Jan 4, 2019

Conversation

Projects
None yet
5 participants
@xabbuh
Copy link
Member

xabbuh commented Jan 4, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.4 milestone Jan 4, 2019

@chalasr

chalasr approved these changes Jan 4, 2019

@fabpot

fabpot approved these changes Jan 4, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 4, 2019

Thank you @xabbuh.

@fabpot fabpot merged commit 99448c6 into symfony:3.4 Jan 4, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jan 4, 2019

minor #29776 remove no longer needed PHP version checks (xabbuh)
This PR was merged into the 3.4 branch.

Discussion
----------

remove no longer needed PHP version checks

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

99448c6 remove no longer needed PHP version checks

@xabbuh xabbuh deleted the xabbuh:php-version branch Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment