Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Profiler] Still show locale and fallback locale even if no trans used #29780

Merged
merged 1 commit into from Jan 5, 2019

Conversation

Projects
None yet
4 participants
@ogizanagi
Copy link
Member

commented Jan 4, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

Even if no translation is used for the current request, this information can still be valuable and displayed in the panel.

Before

capture d ecran 2019-01-04 a 18 03 03

After

capture d ecran 2019-01-04 a 18 01 06

and with messages, move locales info first:

capture d ecran 2019-01-04 a 18 01 18

Actually, following metrics are redundant with the tabs count. Not convinced we should duplicate it.

Edit: removed


Note we also collect the locale set into the request from the RequestDataCollector, but we never use it. Should we display it somewhere in the request panel?

@ogizanagi ogizanagi requested a review from javiereguiluz Jan 4, 2019

@ogizanagi ogizanagi force-pushed the ogizanagi:profiler/trans-panel-locales branch from cfb273a to 8ed2776 Jan 4, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jan 4, 2019

I would indeed remove the duplicated metrics.

@ro0NL

ro0NL approved these changes Jan 4, 2019

@ogizanagi ogizanagi changed the title [Profiler] Still show locale and fallback locale even if not trans used [Profiler] Still show locale and fallback locale even if no trans used Jan 4, 2019

@fabpot

fabpot approved these changes Jan 5, 2019

@fabpot fabpot force-pushed the ogizanagi:profiler/trans-panel-locales branch from 9a654f6 to d80bfad Jan 5, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jan 5, 2019

Thank you @ogizanagi.

@fabpot fabpot merged commit d80bfad into symfony:master Jan 5, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jan 5, 2019

feature #29780 [Profiler] Still show locale and fallback locale even …
…if no trans used (ogizanagi)

This PR was squashed before being merged into the 4.3-dev branch (closes #29780).

Discussion
----------

[Profiler] Still show locale and fallback locale even if no trans used

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | no
| New feature?  | yes <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Even if no translation is used for the current request, this information can still be valuable and displayed in the panel.

### Before

![capture d ecran 2019-01-04 a 18 03 03](https://user-images.githubusercontent.com/2211145/50701531-6933b280-104e-11e9-87a9-1f22ddfd7dc5.png)

### After

![capture d ecran 2019-01-04 a 18 01 06](https://user-images.githubusercontent.com/2211145/50701539-718bed80-104e-11e9-8293-388e9c6ee240.png)

and with messages, move locales info first:

![capture d ecran 2019-01-04 a 18 01 18](https://user-images.githubusercontent.com/2211145/50701593-96806080-104e-11e9-835e-1f207f720616.png)

Actually, following metrics are redundant with the tabs count. Not convinced we should duplicate it.

Edit: removed

---

Note we also collect the locale set into the request from the `RequestDataCollector`, but we never use it. Should we display it somewhere in the request panel?

Commits
-------

d80bfad [Profiler] Still show locale and fallback locale even if no trans used

@ogizanagi ogizanagi deleted the ogizanagi:profiler/trans-panel-locales branch Jan 5, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.