Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Add trim env processor #29781

Merged
merged 1 commit into from Jan 6, 2019

Conversation

Projects
None yet
5 participants
@ogizanagi
Copy link
Member

ogizanagi commented Jan 4, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #26708
License MIT
Doc PR symfony/symfony-docs#10851

Which is especially useful in combination with the file env processor.

@ogizanagi

This comment has been minimized.

Copy link
Member Author

ogizanagi commented Jan 4, 2019

(fabbot failure fixed in b309344)

@xabbuh

This comment has been minimized.

Copy link
Member

xabbuh commented Jan 4, 2019

Should we add it to the changelog?

@ogizanagi ogizanagi force-pushed the ogizanagi:trim_processor branch from 1f43981 to e226492 Jan 5, 2019

@ogizanagi

This comment has been minimized.

Copy link
Member Author

ogizanagi commented Jan 5, 2019

Changelog entry added, thanks

@ogizanagi ogizanagi referenced this pull request Jan 5, 2019

Closed

[RFC] Trim environment #26708

@fabpot

fabpot approved these changes Jan 5, 2019

@xabbuh

xabbuh approved these changes Jan 5, 2019

@xabbuh

xabbuh approved these changes Jan 5, 2019

@chalasr

chalasr approved these changes Jan 5, 2019

@fabpot

fabpot approved these changes Jan 6, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 6, 2019

Thank you @ogizanagi.

@fabpot fabpot merged commit e226492 into symfony:master Jan 6, 2019

0 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Some changes should be done to comply with our standards.
Details

fabpot added a commit that referenced this pull request Jan 6, 2019

feature #29781 [DI] Add trim env processor (ogizanagi)
This PR was merged into the 4.3-dev branch.

Discussion
----------

[DI] Add trim env processor

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #26708  <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | Todo

Which is especially useful in combination with the `file` env processor.

Commits
-------

e226492 [DI] Add trim env processor

@ogizanagi ogizanagi deleted the ogizanagi:trim_processor branch Jan 6, 2019

javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Jan 7, 2019

minor #10851 [DI] Document the `trim` env var processor (ogizanagi)
This PR was merged into the master branch.

Discussion
----------

[DI] Document the `trim` env var processor

Ref: symfony/symfony#29781

Commits
-------

d36f631 [DI] Document the `trim` env var processor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.