New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpFoundation] MemcachedSessionHandler::close() must close connection #29783

Merged
merged 1 commit into from Jan 25, 2019

Conversation

Projects
None yet
6 participants
@grachevko
Copy link
Contributor

grachevko commented Jan 4, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

Intoduced here #3333

@grachevko grachevko changed the base branch from master to 3.4 Jan 4, 2019

@grachevko grachevko force-pushed the grachevko:bugfix/memcached-close branch 4 times, most recently from b77e76a to 2bd3c98 Jan 6, 2019

@grachevko grachevko force-pushed the grachevko:bugfix/memcached-close branch from 2bd3c98 to 38a9d8b Jan 6, 2019

@chalasr chalasr added this to the 3.4 milestone Jan 8, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 17, 2019

/cc @stof Can you have a look here as you did the opposite patch in the referenced PR?

@SpacePossum

This comment has been minimized.

Copy link
Contributor

SpacePossum commented Jan 17, 2019

Kindly note: in the linked PR the call to Memcached#close was removed (👍 ), here however the call to Memcached#quit is proposed. That method is around since 2.0.0 but feature detection could be applied.

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Jan 25, 2019

Thank you @grachevko.

@nicolas-grekas nicolas-grekas merged commit 38a9d8b into symfony:3.4 Jan 25, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jan 25, 2019

bug #29783 [HttpFoundation] MemcachedSessionHandler::close() must clo…
…se connection (grachevko)

This PR was merged into the 3.4 branch.

Discussion
----------

[HttpFoundation] MemcachedSessionHandler::close() must close connection

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| License       | MIT

Intoduced here #3333

Commits
-------

38a9d8b [Bugfix] MemcachedSessionHandler::close() must close connection

@grachevko grachevko deleted the grachevko:bugfix/memcached-close branch Jan 25, 2019

This was referenced Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment