New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fabbot] enable short arrays #29811

Merged
merged 1 commit into from Jan 8, 2019

Conversation

Projects
None yet
5 participants
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jan 7, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Let's move to short arrays, but let's do it in a smooth way.
This PR enables short arrays for php-cs-fixer, making PRs red when they don't follow the CS.
We should then ask all authors of pending PRs to rebase their PR and apply the CS patch.
This will need some time.
Then, in 1-2 months, we'll be able to move all the code base to short arrays without creating hundred merge conflicts with all pending PRs, hopefully.

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Jan 7, 2019

@dunglas

dunglas approved these changes Jan 7, 2019

@chalasr

chalasr approved these changes Jan 8, 2019

@fabpot

fabpot approved these changes Jan 8, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 8, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 84e72e0 into symfony:3.4 Jan 8, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

fabpot added a commit that referenced this pull request Jan 8, 2019

minor #29811 [fabbot] enable short arrays (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[fabbot] enable short arrays

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Let's move to short arrays, but let's do it in a smooth way.
This PR enables short arrays for php-cs-fixer, making PRs red when they don't follow the CS.
We should then ask all authors of pending PRs to rebase their PR and apply the CS patch.
This will need some time.
Then, in 1-2 months, we'll be able to move all the code base to short arrays without creating hundred merge conflicts with all pending PRs, hopefully.

Commits
-------

84e72e0 [fabbot] enable short arrays
@@ -10,7 +10,6 @@ return PhpCsFixer\Config::create()
'@Symfony:risky' => true,
'@PHPUnit48Migration:risky' => true,
'php_unit_no_expectation_annotation' => false, // part of `PHPUnitXYMigration:risky` ruleset, to be enabled when PHPUnit 4.x support will be dropped, as we don't want to rewrite exceptions handling twice
'array_syntax' => array('syntax' => 'long'),

This comment has been minimized.

@fabpot

fabpot Jan 8, 2019

Member

That does not work as "long" is the default. see 3245cb4

javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Jan 15, 2019

minor #10875 Short array syntax (ricknox, jmsche)
This PR was merged into the 3.4 branch.

Discussion
----------

Short array syntax

Now that symfony/symfony/pull/29811 is done we need to reflect these changes in the documentation.

Commits
-------

eac8e90 Apply suggestions/improvements from code review.
535d3a9 Apply suggestions/improvements from code review.
a4440f9 chore: (2/2) Replace long with short syntax.
96f68fe chore: (1/2) Replace long with short syntax.
10e3a9e fix: Swap long with short syntax.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment