Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[EventDispatcher] Fix unknown priority #29822
Somehow, after #29411 the profiler actually shows the security firewall
This listener removes itself at call time, but at this point it's wrapped reference is already in the call stack; to be displayed in the profiler.
Because the wrapped listener lazily collects its priority - it asks it from the dispatcher - we get null; the listener was already removed.
This causes the profiler to render
This fixes it by always passing the expected priority at call time.
The PR conflicts a bit with upstream, during added constructor hints. Let me know what to do, i wasnt necessarily aiming to deprecate not passing this new argument, nor do i want to add a new setter.
Also im not sure about applying all short array changes here&now, on 3.4
edit: dropped the constructor arg, but still conflicts :)