New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TwigBridge] account for the short array syntax in Twig #29829

Merged
merged 1 commit into from Jan 11, 2019

Conversation

Projects
None yet
5 participants
@xabbuh
Copy link
Member

xabbuh commented Jan 10, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.4 milestone Jan 10, 2019

@xabbuh xabbuh force-pushed the xabbuh:twig-short-array-syntax branch from 59a4dc6 to 404192f Jan 10, 2019

@xabbuh

This comment has been minimized.

Copy link
Member

xabbuh commented Jan 10, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 10, 2019

I would only change the generated code as changing the PHP code should be done globally.

@xabbuh

This comment has been minimized.

Copy link
Member

xabbuh commented Jan 10, 2019

I thought the reasoning was in fact to do this step by step (see #29811)?

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 10, 2019

For new code, yes, but not for existing code (to avoid too many issues when merging up).

@xabbuh xabbuh force-pushed the xabbuh:twig-short-array-syntax branch from 404192f to 59a4dc6 Jan 10, 2019

@fabpot

fabpot approved these changes Jan 11, 2019

@xabbuh xabbuh merged commit 59a4dc6 into symfony:3.4 Jan 11, 2019

2 of 3 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

xabbuh added a commit that referenced this pull request Jan 11, 2019

minor #29829 [TwigBridge] account for the short array syntax in Twig …
…(xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[TwigBridge] account for the short array syntax in Twig

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

59a4dc6 account for the short array syntax in Twig

@xabbuh xabbuh deleted the xabbuh:twig-short-array-syntax branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment