New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] pass project dir into the assets install command #29840

Merged
merged 1 commit into from Jan 13, 2019

Conversation

Projects
None yet
4 participants
@xabbuh
Copy link
Member

xabbuh commented Jan 10, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets #29708 (comment)
License MIT
Doc PR

@xabbuh xabbuh force-pushed the xabbuh:pr-29708 branch from ea57298 to b373d42 Jan 11, 2019

@fabpot

fabpot approved these changes Jan 13, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 13, 2019

Thank you @xabbuh.

@fabpot fabpot merged commit b373d42 into symfony:master Jan 13, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jan 13, 2019

feature #29840 [FrameworkBundle] pass project dir into the assets ins…
…tall command (xabbuh)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[FrameworkBundle] pass project dir into the assets install command

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #29708 (comment)
| License       | MIT
| Doc PR        |

Commits
-------

b373d42 pass project dir into the assets install command

@xabbuh xabbuh deleted the xabbuh:pr-29708 branch Jan 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment