New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] xliff-version option to translation update command #29850

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@andrewwro
Copy link

andrewwro commented Jan 11, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? no
License MIT

New 'version' option added to xliff translation update command. Currently xliff version is hardcoded to 1.2.

@andrewwro andrewwro changed the title Added xliff-version option to update translation file [FrameworkBundle] xliff-version option to translation update command Jan 11, 2019

@javiereguiluz
Copy link
Member

javiereguiluz left a comment

I wondered if we should validate the given version somehow ... but in addition to complicating things, not doing that gives more flexibility for edge-cases where developers may need to use a non-standard looking version. So I think the proposed changes are enough. Thanks!

@fabpot

fabpot approved these changes Jan 14, 2019

@stof

This comment has been minimized.

Copy link
Member

stof commented Jan 14, 2019

@javiereguiluz the XliffDumper already validates the version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment