New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "bug #29597 [DI] fix reporting bindings on overriden services as unused" #29853

Merged
merged 1 commit into from Jan 13, 2019

Conversation

Projects
None yet
6 participants
@mmarynich
Copy link
Contributor

mmarynich commented Jan 11, 2019

This reverts commit 44e9a91, reversing
changes made to 91b28ff.

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29836
License MIT
Doc PR

4.2.2 release changed the way tagged service are injected

As asked by @nicolas-grekas #29836 (comment)

Revert "bug #29597 [DI] fix reporting bindings on overriden services …
…as unused (nicolas-grekas)"

This reverts commit 44e9a91, reversing
changes made to 91b28ff.

@nicolas-grekas nicolas-grekas changed the title Revert "bug #29597 [DI] fix reporting bindings on overriden services … Revert "bug #29597 [DI] fix reporting bindings on overriden services as unused" Jan 11, 2019

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Jan 11, 2019

@lyrixx

lyrixx approved these changes Jan 11, 2019

Copy link
Member

lyrixx left a comment

This will reopen #28326

@fabpot

fabpot approved these changes Jan 13, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 13, 2019

Thank you @mmarynich.

@fabpot fabpot merged commit b3e17d2 into symfony:3.4 Jan 13, 2019

2 of 3 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

fabpot added a commit that referenced this pull request Jan 13, 2019

bug #29853 Revert "bug #29597 [DI] fix reporting bindings on override…
…n services as unused" (mmarynich)

This PR was merged into the 3.4 branch.

Discussion
----------

Revert "bug #29597 [DI] fix reporting bindings on overriden services as unused"

This reverts commit 44e9a91, reversing
changes made to 91b28ff.

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29836
| License       | MIT
| Doc PR        |

4.2.2 release changed the way tagged service are injected

As asked by @nicolas-grekas #29836 (comment)

Commits
-------

b3e17d2 Revert "bug #29597 [DI] fix reporting bindings on overriden services as unused (nicolas-grekas)"

xabbuh added a commit to xabbuh/symfony that referenced this pull request Jan 14, 2019

fix test after revert of bugfix
In symfony#29853 the bugfix made in symfony#29597 was reverted as it did not work as
expected. This fixture file has been modified after the 3.4 branch was
merged up to account for the changes made in symfony#2957 and must now be
reverted to the former state too.

fabpot added a commit that referenced this pull request Jan 15, 2019

minor #29886 [DependencyInjection] fix test after revert of bugfix (x…
…abbuh)

This PR was merged into the 4.2 branch.

Discussion
----------

[DependencyInjection] fix test after revert of bugfix

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

In #29853 the bugfix made in #29597 was reverted as it did not work as
expected. This fixture file has been modified after the 3.4 branch was
merged up to account for the changes made in #2957 and must now be
reverted to the former state too.

Commits
-------

81f63b1 fix test after revert of bugfix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment