New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debug] remove return type hint for PHP 5 compatibility #29873

Merged
merged 1 commit into from Jan 14, 2019

Conversation

Projects
None yet
6 participants
@xabbuh
Copy link
Member

xabbuh commented Jan 14, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.4 milestone Jan 14, 2019

@fabpot

fabpot approved these changes Jan 14, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 14, 2019

Thank you @xabbuh.

@fabpot fabpot merged commit 1f31471 into symfony:3.4 Jan 14, 2019

0 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Some changes should be done to comply with our standards.
Details

fabpot added a commit that referenced this pull request Jan 14, 2019

bug #29873 [Debug] remove return type hint for PHP 5 compatibility (x…
…abbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[Debug] remove return type hint for PHP 5 compatibility

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

1f31471 remove return type hint for PHP 5 compatibility

@xabbuh xabbuh deleted the xabbuh:pr-29833 branch Jan 14, 2019

This was referenced Jan 29, 2019

@Webonaute

This comment has been minimized.

Copy link

Webonaute commented Feb 4, 2019

This should not have been tracked into 4.1 and 4.2 branch... no? 4.0+ require PHP version 7.1.3 or higher.

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Feb 5, 2019

Not possible, see https://symfony.com/bc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment