New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TwigBridge] fix compatibility with Twig >= 2.6.1 #29875

Merged
merged 1 commit into from Jan 14, 2019

Conversation

Projects
None yet
4 participants
@xabbuh
Copy link
Member

xabbuh commented Jan 14, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets twigphp/Twig#2803
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.4 milestone Jan 14, 2019

@stof

stof approved these changes Jan 14, 2019

@fabpot

fabpot approved these changes Jan 14, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 14, 2019

Thank you @xabbuh.

@fabpot fabpot merged commit 40089fb into symfony:3.4 Jan 14, 2019

2 of 3 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

fabpot added a commit that referenced this pull request Jan 14, 2019

bug #29875 [TwigBridge] fix compatibility with Twig >= 2.6.1 (xabbuh)
This PR was merged into the 3.4 branch.

Discussion
----------

[TwigBridge] fix compatibility with Twig >= 2.6.1

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | twigphp/Twig#2803
| License       | MIT
| Doc PR        |

Commits
-------

40089fb fix compatibility with Twig >= 2.6.1

@xabbuh xabbuh deleted the xabbuh:twig-compat branch Jan 14, 2019

This was referenced Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment