Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BrowserKit] Various changes to the Response class #29881

Merged
merged 3 commits into from Jan 14, 2019

Conversation

Projects
None yet
5 participants
@fabpot
Copy link
Member

commented Jan 14, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

This is the first PR of a series when I'm trying to "modernize" BrowserKit.

*
* @return int The response status code
*/
public function getStatusCode(): int

This comment has been minimized.

Copy link
@fabpot

fabpot Jan 14, 2019

Author Member

Consistent with the method name used by HttpFoundation

*/
class Response
{
/** @internal */

This comment has been minimized.

Copy link
@fabpot

fabpot Jan 14, 2019

Author Member

@final is enough, just to be extra clear.

@fabpot fabpot force-pushed the fabpot:response-browserkit branch 2 times, most recently from fb40550 to c13438c Jan 14, 2019

@fabpot fabpot force-pushed the fabpot:response-browserkit branch from c13438c to 9045a4e Jan 14, 2019

@stof

stof approved these changes Jan 14, 2019

@fabpot fabpot merged commit 9045a4e into symfony:master Jan 14, 2019

0 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Some changes should be done to comply with our standards.
Details

fabpot added a commit that referenced this pull request Jan 14, 2019

feature #29881 [BrowserKit] Various changes to the Response class (fa…
…bpot)

This PR was squashed before being merged into the 4.3-dev branch (closes #29881).

Discussion
----------

[BrowserKit] Various changes to the Response class

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

This is the first PR of a series when I'm trying to "modernize" BrowserKit.

Commits
-------

9045a4e [BrowserKit] marked Response as @Final
0abff98 [BrowserKit] deprecated Response::buildHeader()
e8e5235 [BrowserKit] deprecated Response::getStatus() in favor of Response::getStatusCode()

@fabpot fabpot deleted the fabpot:response-browserkit branch Jan 17, 2019

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.