New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] CsrfValidationListener marks the token as invalid if it is not a string #29884

Merged
merged 1 commit into from Feb 7, 2019

Conversation

Projects
None yet
5 participants
@umpirsky
Copy link
Contributor

umpirsky commented Jan 14, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29882
License MIT
@xabbuh

This comment has been minimized.

Copy link
Member

xabbuh commented Jan 14, 2019

3.4 is affected by this too, isn't it?

@umpirsky

This comment has been minimized.

Copy link
Contributor Author

umpirsky commented Jan 15, 2019

3.4 is affected by this too, isn't it?

Yes, the fix probably need to be applied there too.

@xabbuh xabbuh changed the base branch from 4.2 to 3.4 Jan 15, 2019

@xabbuh

This comment has been minimized.

Copy link
Member

xabbuh commented Jan 15, 2019

@umpirsky Can you rebase on the 3.4 branch? :)

@umpirsky

This comment has been minimized.

Copy link
Contributor Author

umpirsky commented Jan 15, 2019

It will be easier to create a new PR. :)

@xabbuh

This comment has been minimized.

Copy link
Member

xabbuh commented Jan 15, 2019

@umpirsky if you'd like to, I can have a look at this PR and rebase it

@umpirsky

This comment has been minimized.

Copy link
Contributor Author

umpirsky commented Jan 15, 2019

I will look into it soon...

@umpirsky umpirsky force-pushed the umpirsky:fix-29882-4.2 branch from 9feae63 to ad6f0dc Jan 15, 2019

@umpirsky

This comment has been minimized.

Copy link
Contributor Author

umpirsky commented Jan 15, 2019

I reset to 3.4 and cherry-picked changes. Thanks for the patience!

@xabbuh

xabbuh approved these changes Jan 15, 2019

@xabbuh xabbuh added this to the 3.4 milestone Jan 15, 2019

@umpirsky

This comment has been minimized.

Copy link
Contributor Author

umpirsky commented Jan 18, 2019

Status?

@nicolas-grekas
Copy link
Member

nicolas-grekas left a comment

Please rebase + change the PR title to make the changelog usefull.
Good to me otherwise!

@umpirsky umpirsky force-pushed the umpirsky:fix-29882-4.2 branch from a905812 to 86aab3f Jan 26, 2019

@umpirsky umpirsky changed the title Fixes issue #29882 CsrfValidationListener marks the token as invalid if it is not a string Jan 26, 2019

@umpirsky

This comment has been minimized.

Copy link
Contributor Author

umpirsky commented Jan 26, 2019

Updated.

@umpirsky umpirsky closed this Jan 26, 2019

@umpirsky umpirsky reopened this Jan 26, 2019

@xabbuh xabbuh added the Validator label Jan 26, 2019

@xabbuh xabbuh requested a review from nicolas-grekas Feb 2, 2019

@xabbuh xabbuh added the Form label Feb 2, 2019

@nicolas-grekas nicolas-grekas changed the title CsrfValidationListener marks the token as invalid if it is not a string [Form] CsrfValidationListener marks the token as invalid if it is not a string Feb 7, 2019

@nicolas-grekas nicolas-grekas force-pushed the umpirsky:fix-29882-4.2 branch from 86aab3f to deb8e95 Feb 7, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Feb 7, 2019

Thank you @umpirsky.

@nicolas-grekas nicolas-grekas merged commit deb8e95 into symfony:3.4 Feb 7, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Feb 7, 2019

bug #29884 [Form] CsrfValidationListener marks the token as invalid i…
…f it is not a string (umpirsky)

This PR was squashed before being merged into the 3.4 branch (closes #29884).

Discussion
----------

[Form] CsrfValidationListener marks the token as invalid if it is not a string

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29882
| License       | MIT

Commits
-------

deb8e95 [Form] CsrfValidationListener marks the token as invalid if it is not a string

@umpirsky umpirsky deleted the umpirsky:fix-29882-4.2 branch Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment