New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DependencyInjection] the string "0" is a valid service identifier #29894

Merged
merged 1 commit into from Jan 15, 2019

Conversation

Projects
None yet
4 participants
@xabbuh
Copy link
Member

xabbuh commented Jan 15, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29854
License MIT
Doc PR
@fabpot

fabpot approved these changes Jan 15, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 15, 2019

Thank you @xabbuh.

@fabpot fabpot merged commit caca373 into symfony:3.4 Jan 15, 2019

2 of 3 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

fabpot added a commit that referenced this pull request Jan 15, 2019

bug #29894 [DependencyInjection] the string "0" is a valid service id…
…entifier (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[DependencyInjection] the string "0" is a valid service identifier

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29854
| License       | MIT
| Doc PR        |

Commits
-------

caca373 the string "0" is a valid service identifier

@xabbuh xabbuh deleted the xabbuh:issue-29854 branch Jan 15, 2019

This was referenced Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment