New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cache] PDO-based cache pool table autocreation does not work #29900

Merged
merged 1 commit into from Jan 25, 2019

Conversation

Projects
None yet
3 participants
@errogaht
Copy link
Contributor

errogaht commented Jan 16, 2019

look at #29898
I believe that it is not good fix... But pgsq table not foutd throwed right there, in execute(). Dont know about another DB drivers, and i dont know will execute() again work or not, please if some one know more about PDO than me, check it!

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29898
License MIT

@nicolas-grekas nicolas-grekas changed the title [FrameworkBundle][Cache] PDO-based cache pool table autocreation does… [FrameworkBundle][Cache] PDO-based cache pool table autocreation does not work Jan 24, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Jan 24, 2019

Hi @errogaht thanks for the PR, it looks good to me.
Could you please rebase+retarget branch 4.2?
You'll also need to fix the short array syntax we're using now.

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone Jan 24, 2019

@nicolas-grekas nicolas-grekas changed the base branch from master to 4.2 Jan 25, 2019

@nicolas-grekas nicolas-grekas force-pushed the errogaht:cache-pdo-autocreation-fix branch from c03b335 to 81d3716 Jan 25, 2019

@nicolas-grekas nicolas-grekas changed the title [FrameworkBundle][Cache] PDO-based cache pool table autocreation does not work [Cache] PDO-based cache pool table autocreation does not work Jan 25, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Jan 25, 2019

Thank you @errogaht.

@nicolas-grekas nicolas-grekas merged commit 81d3716 into symfony:4.2 Jan 25, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jan 25, 2019

bug #29900 [Cache] PDO-based cache pool table autocreation does not w…
…ork (errogaht)

This PR was merged into the 4.2 branch.

Discussion
----------

[Cache] PDO-based cache pool table autocreation does not work

look at #29898
I believe that it is not good fix... But pgsq table not foutd throwed right there, in execute(). Dont know about another DB drivers, and i dont know will execute() again work or not, please if some one know more about PDO than me, check it!

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29898
| License       | MIT

Commits
-------

81d3716 [Cache] PDO-based cache pool table autocreation does not work
@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Jan 25, 2019

Actually, some db engine (eg sqlite) check table existency at prepare time, as spotted by the CI. I'm adding back the removed code.

@errogaht

This comment has been minimized.

Copy link
Contributor Author

errogaht commented Jan 25, 2019

@errogaht

This comment has been minimized.

Copy link
Contributor Author

errogaht commented Jan 28, 2019

@nicolas-grekas fixed, please check #30005

nicolas-grekas added a commit that referenced this pull request Feb 1, 2019

bug #30050 [Cache] fix pruning pdo cache for vendors that throw on ex…
…ecute (bendavies)

This PR was merged into the 4.2 branch.

Discussion
----------

[Cache] fix pruning pdo cache for vendors that throw on execute

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no >
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

This additionally fixes pruning of the PdoAdapter when the table does not exist.
Similar to #29900 #30005 and f419851

Commits
-------

14b9fa5 fix pruning pdo cache for vendors that throw on execute

@fabpot fabpot referenced this pull request Feb 3, 2019

Merged

Release v4.2.3 #30068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment