New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debug][DebugClassLoader] Match more cases for final, deprecated and internal classes / methods extends #29920

Merged
merged 1 commit into from Jan 24, 2019

Conversation

Projects
None yet
3 participants
@fancyweb
Copy link
Contributor

fancyweb commented Jan 17, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Currently, when there is no comment for a tag and another tag after, the detection does not work. Example :

/**
 * @final
 *
 * @author John
 */
class A {

}

AFAIK, those tags must not be in a specific order. That's why we should try to support more cases because we might miss things to report.

Also I do not understand why the regex is not the same for the classes and methods detection. I fixed that too.

I added a lot of cases in the "extends from final class" test and an easy way to add more when needed. Adding them everywhere might be overkill and useless. WDYT ?

I'm considering this as bug fix.

@nicolas-grekas
Copy link
Member

nicolas-grekas left a comment

LGTM thanks.
BTW, if you'd like to have a look at #29969, it's on the same line :)

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Jan 24, 2019

Thank you @fancyweb.

@nicolas-grekas nicolas-grekas merged commit c3b670a into symfony:3.4 Jan 24, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

nicolas-grekas added a commit that referenced this pull request Jan 24, 2019

bug #29920 [Debug][DebugClassLoader] Match more cases for final, depr…
…ecated and internal classes / methods extends (fancyweb)

This PR was merged into the 3.4 branch.

Discussion
----------

[Debug][DebugClassLoader] Match more cases for final, deprecated and internal classes / methods extends

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Currently, when there is no comment for a tag and another tag after, the detection does not work. Example :
```php
/**
 * @Final
 *
 * @author John
 */
class A {

}
```

AFAIK, those tags must not be in a specific order. That's why we should try to support more cases because we might miss things to report.

Also I do not understand why the regex is not the same for the classes and methods detection. I fixed that too.

I added a lot of cases in the "extends from final class" test and an easy way to add more when needed. Adding them everywhere might be overkill and useless. WDYT ?

I'm considering this as bug fix.

Commits
-------

c3b670a [Debug][DebugClassLoader] Match more cases for final, deprecated and internal classes / methods extends

This was referenced Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment