New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid dots in generated class names #29922

Merged
merged 1 commit into from Jan 20, 2019

Conversation

Projects
None yet
5 participants
@derrabus
Copy link
Contributor

derrabus commented Jan 17, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29921
License MIT
Doc PR N/A

This PR removes dots from class names containers generated out of anonymous kernel classes.

@xabbuh xabbuh added this to the 4.2 milestone Jan 18, 2019

@nicolas-grekas
Copy link
Member

nicolas-grekas left a comment

On one line please :)

@derrabus derrabus force-pushed the derrabus:bugfix/anonymous-class-name branch from a8875a5 to 52c80e6 Jan 19, 2019

@derrabus

This comment has been minimized.

Copy link
Contributor Author

derrabus commented Jan 19, 2019

Done.

@fabpot

fabpot approved these changes Jan 20, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 20, 2019

Thank you @derrabus.

@fabpot fabpot merged commit 52c80e6 into symfony:4.2 Jan 20, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jan 20, 2019

bug #29922 Avoid dots in generated class names (derrabus)
This PR was merged into the 4.2 branch.

Discussion
----------

Avoid dots in generated class names

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29921
| License       | MIT
| Doc PR        | N/A

This PR removes dots from class names containers generated out of anonymous kernel classes.

Commits
-------

52c80e6 Avoid dots in generated class names.

@derrabus derrabus deleted the derrabus:bugfix/anonymous-class-name branch Jan 21, 2019

@fabpot fabpot referenced this pull request Feb 3, 2019

Merged

Release v4.2.3 #30068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment