Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAvoid dots in generated class names #29922
+1
−1
Conversation
carsonbot
added
Status: Needs Review
Bug
labels
Jan 17, 2019
xabbuh
added this to the 4.2 milestone
Jan 18, 2019
carsonbot
added
Status: Reviewed
and removed
Status: Needs Review
labels
Jan 18, 2019
derrabus
force-pushed the
derrabus:bugfix/anonymous-class-name
branch
from
a8875a5
to
52c80e6
Jan 19, 2019
This comment has been minimized.
This comment has been minimized.
|
Done. |
fabpot
approved these changes
Jan 20, 2019
This comment has been minimized.
This comment has been minimized.
|
Thank you @derrabus. |
fabpot
merged commit 52c80e6
into
symfony:4.2
Jan 20, 2019
added a commit
that referenced
this pull request
Jan 20, 2019
derrabus
deleted the
derrabus:bugfix/anonymous-class-name
branch
Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
derrabus commentedJan 17, 2019
This PR removes dots from class names containers generated out of anonymous kernel classes.