New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] Changed UrlType input type to text when default_protocol is not null #29926

Merged
merged 1 commit into from Jan 25, 2019

Conversation

Projects
None yet
5 participants
@xabbuh
Copy link
Member

xabbuh commented Jan 18, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29690
License MIT
Doc PR

replaces #29691

@xabbuh xabbuh added this to the 3.4 milestone Jan 18, 2019

@stof

stof approved these changes Jan 23, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Jan 25, 2019

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 2791edf into symfony:3.4 Jan 25, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jan 25, 2019

bug #29926 [Form] Changed UrlType input type to text when default_pro…
…tocol is not null (MatTheCat)

This PR was merged into the 3.4 branch.

Discussion
----------

[Form] Changed UrlType input type to text when default_protocol is not null

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29690
| License       | MIT
| Doc PR        |

replaces #29691

Commits
-------

2791edf [Form] Changed UrlType input type to text when default_protocol is not null
@MatTheCat

This comment has been minimized.

Copy link
Contributor

MatTheCat commented Jan 25, 2019

👏

@xabbuh

This comment has been minimized.

Copy link
Member Author

xabbuh commented Jan 25, 2019

Thank you @MatTheCat.

@xabbuh xabbuh deleted the xabbuh:pr-29691 branch Jan 25, 2019

This was referenced Jan 29, 2019

@j0k3r j0k3r referenced this pull request Feb 5, 2019

Merged

Fix Giphy image/url parameter #203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment