Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mime] Add a set of default content-types for some extensions #29936

Merged
merged 1 commit into from Jan 27, 2019

Conversation

Projects
None yet
5 participants
@fabpot
Copy link
Member

commented Jan 20, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Some extensions have many possible content-types. This PR forces the first (preferred) content type for some extensions (the preset comes from Swiftmailer).

@nicolas-grekas nicolas-grekas added this to the next milestone Jan 24, 2019

@nicolas-grekas
Copy link
Member

left a comment

(with two minor comments that'd be nice fixing.)

@xabbuh

xabbuh approved these changes Jan 27, 2019

@fabpot fabpot force-pushed the fabpot:mime-types-preferences branch from 26b6d78 to 2912796 Jan 27, 2019

@fabpot fabpot force-pushed the fabpot:mime-types-preferences branch from 2912796 to 37065d4 Jan 27, 2019

@fabpot fabpot merged commit 37065d4 into symfony:master Jan 27, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jan 27, 2019

feature #29936 [Mime] Add a set of default content-types for some ext…
…ensions (fabpot)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Mime] Add a set of default content-types for some extensions

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Some extensions have many possible content-types. This PR forces the first (preferred) content type for some extensions (the preset comes from Swiftmailer).

Commits
-------

37065d4 [Mime] added a set of default content-types for some extensions

@fabpot fabpot deleted the fabpot:mime-types-preferences branch Mar 4, 2019

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.