New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Translation] Concatenated translation messages #29961

Merged
merged 1 commit into from Jan 25, 2019

Conversation

Projects
None yet
4 participants
@Stadly
Copy link
Contributor

Stadly commented Jan 23, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29956
License MIT
Doc PR none

Concatenated translation messages are now treated correctly.

@fabpot

fabpot approved these changes Jan 23, 2019

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Jan 24, 2019

@nicolas-grekas nicolas-grekas changed the title Concatenated translation messages [Translation] Concatenated translation messages Jan 24, 2019

@nicolas-grekas nicolas-grekas force-pushed the Stadly:concat-translation branch from cf6647a to df73ebf Jan 25, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Jan 25, 2019

Thank you @Stadly.

@nicolas-grekas nicolas-grekas merged commit df73ebf into symfony:3.4 Jan 25, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jan 25, 2019

bug #29961 [Translation] Concatenated translation messages (Stadly)
This PR was squashed before being merged into the 3.4 branch (closes #29961).

Discussion
----------

[Translation] Concatenated translation messages

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29956
| License       | MIT
| Doc PR        | none

Concatenated translation messages are now treated correctly.

Commits
-------

df73ebf [Translation] Concatenated translation messages

@Stadly Stadly deleted the Stadly:concat-translation branch Jan 25, 2019

This was referenced Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment