New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VarDumper] Fixed search bar #29984

Merged
merged 1 commit into from Jan 27, 2019

Conversation

Projects
None yet
6 participants
@ro0NL
Copy link
Contributor

ro0NL commented Jan 25, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

Continuation of #28854, replaces #29176

initial:

image

ctrl f:

image

scroll:

image

tested in chrome+ff

cc @ogizanagi

ref https://caniuse.com/#feat=css-sticky

@ro0NL

This comment has been minimized.

Copy link
Contributor Author

ro0NL commented Jan 25, 2019

made sure the first result wont be hidden under the search bar:

image

i think this nails it :)

@ro0NL ro0NL force-pushed the ro0NL:dumper branch 3 times, most recently from 76bf5fb to f157564 Jan 25, 2019

@ogizanagi
Copy link
Member

ogizanagi left a comment

Thanks for working on this ❤️

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 25, 2019

Shouldn't we merge this one on an older branch?

@ro0NL ro0NL force-pushed the ro0NL:dumper branch from f157564 to 579892c Jan 25, 2019

@ro0NL ro0NL changed the base branch from master to 4.2 Jan 25, 2019

@Koc

This comment has been minimized.

Copy link
Contributor

Koc commented Jan 26, 2019

Is it possible to disable this search bar in general?

@ro0NL

This comment has been minimized.

Copy link
Contributor Author

ro0NL commented Jan 27, 2019

@Koc see #29748, IMHO it's developer preference so im not sure how to deal with it. Different topic though :)

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone Jan 27, 2019

@nicolas-grekas nicolas-grekas force-pushed the ro0NL:dumper branch from 76c5948 to 99d2893 Jan 27, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Jan 27, 2019

Thank you @ro0NL.

@nicolas-grekas nicolas-grekas merged commit 99d2893 into symfony:4.2 Jan 27, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jan 27, 2019

bug #29984 [VarDumper] Fixed search bar (ro0NL)
This PR was squashed before being merged into the 4.2 branch (closes #29984).

Discussion
----------

[VarDumper] Fixed search bar

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Continuation of #28854, replaces #29176

initial:

![image](https://user-images.githubusercontent.com/1047696/51747953-3c9e1400-20ab-11e9-913d-d60bd59ee2d9.png)

ctrl f:

![image](https://user-images.githubusercontent.com/1047696/51747973-4b84c680-20ab-11e9-8d07-e6128822fbb2.png)

scroll:

![image](https://user-images.githubusercontent.com/1047696/51747984-550e2e80-20ab-11e9-8b54-b24109d2280a.png)

tested in chrome+ff

cc @ogizanagi

ref https://caniuse.com/#feat=css-sticky

Commits
-------

99d2893 [VarDumper] Fixed search bar

@ro0NL ro0NL deleted the ro0NL:dumper branch Jan 27, 2019

@fabpot fabpot referenced this pull request Feb 3, 2019

Merged

Release v4.2.3 #30068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment