New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format strings for deprecation notices #30004

Merged
merged 1 commit into from Jan 28, 2019

Conversation

Projects
None yet
5 participants
@TysonAndre
Copy link
Contributor

TysonAndre commented Jan 27, 2019

Q A
Branch? master for features / 3.4 up to 4.2 for bug fixes
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass?
Fixed tickets
License MIT
Doc PR

The %c conversion specifier expects an integer
(the value of the byte to print). To produce a literal %, %% should be used.

Detected via static analysis

Fix format strings for deprecation notices
The `%c` conversion specifier expects an integer
(the value of the byte to print)

Detected via static analysis
@xabbuh

xabbuh approved these changes Jan 28, 2019

@xabbuh xabbuh added this to the 4.2 milestone Jan 28, 2019

@xabbuh xabbuh added the Translator label Jan 28, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Jan 28, 2019

Thank you @TysonAndre.

@nicolas-grekas nicolas-grekas merged commit 2e00dfb into symfony:4.2 Jan 28, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jan 28, 2019

bug #30004 Fix format strings for deprecation notices (TysonAndre)
This PR was merged into the 4.2 branch.

Discussion
----------

Fix format strings for deprecation notices

| Q             | A
| ------------- | ---
| Branch?       | master for features / 3.4 up to 4.2 for bug fixes <!-- see below -->
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   |
| Fixed tickets |
| License       | MIT
| Doc PR        |

The `%c` conversion specifier expects an integer
(the value of the byte to print). To produce a literal `%`, `%%` should be used.

Detected via static analysis

Commits
-------

2e00dfb Fix format strings for deprecation notices

@fabpot fabpot referenced this pull request Feb 3, 2019

Merged

Release v4.2.3 #30068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment