Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[Debug] Display more details in the simple error page of Debug #30024
Conversation
javiereguiluz
added
Feature
Debug
labels
Jan 29, 2019
javiereguiluz
added this to the next milestone
Jan 29, 2019
carsonbot
added
the
Status: Needs Review
label
Jan 29, 2019
OskarStark
approved these changes
Jan 29, 2019
carsonbot
added
Status: Reviewed
and removed
Status: Needs Review
labels
Jan 29, 2019
This comment has been minimized.
This comment has been minimized.
|
It doesn't display more details, it displays twice the same information |
This comment has been minimized.
This comment has been minimized.
|
But much more prominent |
nicolas-grekas
approved these changes
Feb 1, 2019
This comment has been minimized.
This comment has been minimized.
|
Thank you @javiereguiluz. |
nicolas-grekas
force-pushed the
javiereguiluz:improve_29891
branch
from
a74dc58
to
75ff151
Feb 7, 2019
nicolas-grekas
merged commit 75ff151
into
symfony:master
Feb 7, 2019
added a commit
that referenced
this pull request
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
javiereguiluz commentedJan 29, 2019
Note: this only changes the simple error page of Debug component, which is different from the full-featured error page of WebProfilerBundle.
#29891 shows a confusing error page. In #29928 we improved the first error message displayed to the user. In this PR we implement @nicolas-grekas' idea to replace the generic error page title by a better error message. So, this PR + #29928 would fix #29891 to me.
Before
After