New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debug] Display more details in the simple error page of Debug #30024

Merged
merged 1 commit into from Feb 7, 2019

Conversation

Projects
None yet
5 participants
@javiereguiluz
Copy link
Member

javiereguiluz commented Jan 29, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29891
License MIT
Doc PR -

Note: this only changes the simple error page of Debug component, which is different from the full-featured error page of WebProfilerBundle.


#29891 shows a confusing error page. In #29928 we improved the first error message displayed to the user. In this PR we implement @nicolas-grekas' idea to replace the generic error page title by a better error message. So, this PR + #29928 would fix #29891 to me.

Before

error-before

After

error-after

@fancyweb

This comment has been minimized.

Copy link
Contributor

fancyweb commented Jan 29, 2019

It doesn't display more details, it displays twice the same information 😕

@OskarStark

This comment has been minimized.

Copy link
Contributor

OskarStark commented Jan 30, 2019

But much more prominent

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Feb 7, 2019

Thank you @javiereguiluz.

@nicolas-grekas nicolas-grekas force-pushed the javiereguiluz:improve_29891 branch from a74dc58 to 75ff151 Feb 7, 2019

@nicolas-grekas nicolas-grekas merged commit 75ff151 into symfony:master Feb 7, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Feb 7, 2019

feature #30024 [Debug] Display more details in the simple error page …
…of Debug (javiereguiluz)

This PR was squashed before being merged into the 4.3-dev branch (closes #30024).

Discussion
----------

[Debug] Display more details in the simple error page of Debug

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29891
| License       | MIT
| Doc PR        | -

Note: this only changes the simple error page of Debug component, which is different from the full-featured error page of WebProfilerBundle.

-----

#29891 shows a confusing error page. In #29928 we improved the first error message displayed to the user. In this PR we implement @nicolas-grekas' idea to replace the generic error page title by a better error message. So, this PR + #29928 would fix #29891 to me.

### Before

![error-before](https://user-images.githubusercontent.com/73419/51920135-1519b500-23e5-11e9-99d6-e9b631b97499.png)

### After

![error-after](https://user-images.githubusercontent.com/73419/51920141-1945d280-23e5-11e9-97c3-49b2170dbd15.png)

Commits
-------

75ff151 [Debug] Display more details in the simple error page of Debug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment