New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VarDumper] dont implement Serializable in Stub #30026

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
None yet
5 participants
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jan 29, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30014
License MIT
Doc PR -

Serializable is really really broken...

{
return \serialize([$this->class, $this->position, $this->cut, $this->type, $this->value, $this->handle, $this->refCount, $this->attr]);
$this->serialized = [$this->class, $this->position, $this->cut, $this->type, $this->value, $this->handle, $this->refCount, $this->attr];

This comment has been minimized.

@xabbuh

xabbuh Jan 30, 2019

Member

Shouldn't we add the property declaration?

This comment has been minimized.

@nicolas-grekas

nicolas-grekas Jan 30, 2019

Author Member

Nope, that's the trick: this is a purely transient state. Declaring a property would mean extra memory used for each instance for zero benefits.

@xabbuh

xabbuh approved these changes Jan 30, 2019

@nicolas-grekas nicolas-grekas merged commit 73070d7 into symfony:3.4 Jan 30, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jan 30, 2019

bug #30026 [VarDumper] dont implement Serializable in Stub (nicolas-g…
…rekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[VarDumper] dont implement Serializable in Stub

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30014
| License       | MIT
| Doc PR        | -

`Serializable` is really really broken...

Commits
-------

73070d7 [VarDumper] dont implement Serializable in Stub

This was referenced Feb 3, 2019

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:vd-sleep branch Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment