New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] fix some docblocks and type checks #30028

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
None yet
6 participants
@xabbuh
Copy link
Member

xabbuh commented Jan 29, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30018
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.4 milestone Jan 29, 2019

@xabbuh xabbuh force-pushed the xabbuh:issue-30018 branch from 01abc67 to d07a419 Jan 29, 2019

@xabbuh xabbuh force-pushed the xabbuh:issue-30018 branch from d07a419 to d63bbd9 Jan 30, 2019

@xabbuh xabbuh force-pushed the xabbuh:issue-30018 branch from d63bbd9 to ec0c371 Jan 30, 2019

@xabbuh

This comment has been minimized.

Copy link
Member Author

xabbuh commented Jan 30, 2019

I have reverted all the string|int changes. Since the FormConfigBuilder is the only class accepting integers as form names we can probably better deprecate that in Symfony 4.3 and add a type hint in 5.0.

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Jan 30, 2019

Isn't there some BC break potential here?

@xabbuh

This comment has been minimized.

Copy link
Member Author

xabbuh commented Jan 30, 2019

The interface declares that the method must return a string. I wouldn't expect anyone to rely on null being returned. And the basic use case for this method is the block prefix for the form theming where null also doesn't make any sense.

@fabpot

fabpot approved these changes Jan 30, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 30, 2019

Thank you @xabbuh.

@fabpot fabpot merged commit ec0c371 into symfony:3.4 Jan 30, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jan 30, 2019

bug #30028 [Form] fix some docblocks and type checks (xabbuh)
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] fix some docblocks and type checks

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30018
| License       | MIT
| Doc PR        |

Commits
-------

ec0c371 [Form] fix some docblocks and type checks

@xabbuh xabbuh deleted the xabbuh:issue-30018 branch Jan 30, 2019

This was referenced Feb 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment