New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system wide memcached.so #30030

Merged
merged 1 commit into from Feb 1, 2019

Conversation

Projects
None yet
3 participants
@tvlooy
Copy link
Contributor

tvlooy commented Jan 29, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? WiP
License MIT

requested by #29624 (comment)

let's see what travis is going to do with this ...

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Jan 30, 2019

@tvlooy tvlooy force-pushed the tvlooy:optimize_travis branch 2 times, most recently from d3c7fc2 to 1337515 Feb 1, 2019

.travis.yml Outdated
@@ -188,30 +188,36 @@ before_install:
tfold ext.mongodb tpecl mongodb-1.6.0alpha1 mongodb.so $INI
fi
echo extension = memcached.so >> $INI

This comment has been minimized.

@nicolas-grekas

nicolas-grekas Feb 1, 2019

Member

should be after the if I suppose, see failures

This comment has been minimized.

@tvlooy

tvlooy Feb 1, 2019

Author Contributor

wheps

.travis.yml Outdated
echo extension = memcached.so >> $INI
echo extension = $ext_cache >> $INI
else
echo extension = memcached.so >> $INI

This comment has been minimized.

@nicolas-grekas

nicolas-grekas Feb 1, 2019

Member

can't we use always this line outside of the if and remove the one before?

This comment has been minimized.

@tvlooy

tvlooy Feb 1, 2019

Author Contributor

I don't think so. The first is from cache and the second is the system wide. The cache is not in the ini path ... Let's try to find out

.travis.yml Outdated
fi
echo extension = memcached.so >> $INI

This comment has been minimized.

@nicolas-grekas

nicolas-grekas Feb 1, 2019

Member

ok, got it, should be inside the previous if (but not inside the nested if), isn't it?

This comment has been minimized.

@tvlooy

tvlooy Feb 1, 2019

Author Contributor

the tests pass but that is not supposed to work. I see that the system wide ext/memcached got bumped to version 3.1.2. See if it works without all the compiling ...

@tvlooy tvlooy force-pushed the tvlooy:optimize_travis branch from 124ead3 to 6b99325 Feb 1, 2019

@tvlooy tvlooy changed the title Use pre-built so file Use system wide memcached.so Feb 1, 2019

@tvlooy

This comment has been minimized.

Copy link
Contributor Author

tvlooy commented Feb 1, 2019

@nicolas-grekas this is better

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Feb 1, 2019

Awesome! Could you move the line back to the php.ini configuration section?

@tvlooy tvlooy force-pushed the tvlooy:optimize_travis branch from 6b99325 to 8d171f4 Feb 1, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Feb 1, 2019

Thank you @tvlooy.

@nicolas-grekas nicolas-grekas merged commit 8d171f4 into symfony:3.4 Feb 1, 2019

0 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Doing some proofreading and checking your coding style.
Details

nicolas-grekas added a commit that referenced this pull request Feb 1, 2019

minor #30030 Use system wide memcached.so (tvlooy)
This PR was merged into the 3.4 branch.

Discussion
----------

Use system wide memcached.so

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | WiP
| License       | MIT

requested by #29624 (comment)

let's see what travis is going to do with this ...

Commits
-------

8d171f4 Use system wide memcached.so
@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Feb 1, 2019

Merged in 4.2, let's see the same for amqp.so?

nicolas-grekas added a commit that referenced this pull request Feb 8, 2019

minor #30057 New extensions were released supporting PHP 7.3 (tvlooy)
This PR was merged into the 4.2 branch.

Discussion
----------

New extensions were released supporting PHP 7.3

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | see travis
| License       | MIT

Requested in #30030

Commits
-------

31de71d New extensions were released supporting PHP 7.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment