New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] ensure moving away from Serializable wont break cache:clear #30034

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jan 30, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

When a resource implementation moves away from Serializable, the cache:clear command currently fails with Warning: Class Symfony\Component\Config\Resource\ClassExistenceResource has no unserializer. This change makes it ignore the failure, which is fine.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:unser-safe branch from 562ea51 to 9d3180a Jan 30, 2019

@xabbuh

xabbuh approved these changes Jan 30, 2019

@nicolas-grekas nicolas-grekas merged commit 9d3180a into symfony:3.4 Jan 30, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jan 30, 2019

bug #30034 [Config] ensure moving away from Serializable wont break c…
…ache:clear (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[Config] ensure moving away from Serializable wont break cache:clear

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

When a resource implementation moves away from `Serializable`, the `cache:clear` command currently fails with `Warning: Class Symfony\Component\Config\Resource\ClassExistenceResource has no unserializer`. This change makes it ignore the failure, which is fine.

Commits
-------

9d3180a [Config] ensure moving away from Serializable wont break cache:clear

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:unser-safe branch Jan 30, 2019

This was referenced Feb 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment