New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Fix dumping Doctrine-like service graphs #30046

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
None yet
2 participants
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jan 30, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30017 #29637 #29693
License MIT
Doc PR -

I'm unable to provide a reproducer for this, the required service reference graph is too crazy, but that does the job :)

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Jan 30, 2019

@nicolas-grekas nicolas-grekas merged commit ed96830 into symfony:3.4 Jan 30, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jan 30, 2019

bug #30046 [DI] Fix dumping Doctrine-like service graphs (nicolas-gre…
…kas)

This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Fix dumping Doctrine-like service graphs

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30017 #29637 #29693
| License       | MIT
| Doc PR        | -

I'm unable to provide a reproducer for this, the required service reference graph is too crazy, but that does the job :)

Commits
-------

ed96830 [DI] Fix dumping Doctrine-like service graphs

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:di-fix branch Feb 1, 2019

This was referenced Feb 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment