Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[Cache] fix pruning pdo cache for vendors that throw on execute #30050
+5
−2
Conversation
carsonbot
added
Status: Needs Review
Bug
labels
Jan 31, 2019
bendavies
changed the base branch from
master
to
4.2
Jan 31, 2019
bendavies
changed the title
fix pruning pdo cache for vendors that throw on execute
[Cache] fix pruning pdo cache for vendors that throw on execute
Jan 31, 2019
nicolas-grekas
approved these changes
Jan 31, 2019
carsonbot
added
Status: Reviewed
and removed
Status: Needs Review
labels
Jan 31, 2019
nicolas-grekas
added this to the 4.2 milestone
Jan 31, 2019
This comment has been minimized.
This comment has been minimized.
|
Shouldnt be a test added/updated? |
This comment has been minimized.
This comment has been minimized.
|
in honestly, i did not check for existing tests as previous fixes for this issue (linked above) added no tests. |
This comment has been minimized.
This comment has been minimized.
|
Maybe this is the reason why this bug occurred afterwards |
This comment has been minimized.
This comment has been minimized.
|
This is already tested - just not on mysql - and we're not going to add a multi-DB infra for this :) |
This comment has been minimized.
This comment has been minimized.
|
Thank you @bendavies. |
nicolas-grekas
merged commit 14b9fa5
into
symfony:4.2
Feb 1, 2019
added a commit
that referenced
this pull request
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
bendavies commentedJan 31, 2019
This additionally fixes pruning of the PdoAdapter when the table does not exist.
Similar to #29900 #30005 and f419851