New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cache] fix pruning pdo cache for vendors that throw on execute #30050

Merged
merged 1 commit into from Feb 1, 2019

Conversation

Projects
None yet
4 participants
@bendavies
Copy link
Contributor

bendavies commented Jan 31, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no >
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

This additionally fixes pruning of the PdoAdapter when the table does not exist.
Similar to #29900 #30005 and f419851

@bendavies bendavies changed the base branch from master to 4.2 Jan 31, 2019

@bendavies bendavies changed the title fix pruning pdo cache for vendors that throw on execute [Cache] fix pruning pdo cache for vendors that throw on execute Jan 31, 2019

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone Jan 31, 2019

@OskarStark

This comment has been minimized.

Copy link
Contributor

OskarStark commented Jan 31, 2019

Shouldnt be a test added/updated?

@bendavies

This comment has been minimized.

Copy link
Contributor Author

bendavies commented Jan 31, 2019

in honestly, i did not check for existing tests as previous fixes for this issue (linked above) added no tests.

@OskarStark

This comment has been minimized.

Copy link
Contributor

OskarStark commented Feb 1, 2019

Maybe this is the reason why this bug occurred afterwards 🙃

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Feb 1, 2019

This is already tested - just not on mysql - and we're not going to add a multi-DB infra for this :)

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Feb 1, 2019

Thank you @bendavies.

@nicolas-grekas nicolas-grekas merged commit 14b9fa5 into symfony:4.2 Feb 1, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Feb 1, 2019

bug #30050 [Cache] fix pruning pdo cache for vendors that throw on ex…
…ecute (bendavies)

This PR was merged into the 4.2 branch.

Discussion
----------

[Cache] fix pruning pdo cache for vendors that throw on execute

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no >
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

This additionally fixes pruning of the PdoAdapter when the table does not exist.
Similar to #29900 #30005 and f419851

Commits
-------

14b9fa5 fix pruning pdo cache for vendors that throw on execute

@fabpot fabpot referenced this pull request Feb 3, 2019

Merged

Release v4.2.3 #30068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment