Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Drop \Serializable implementations #30051
Changes touch these components:
This is a work in progress.
There are some issues to be solved.
I'm not able to mesure the impact of droping
Traces into objects
This new serialization strategy injects a trace into the serialized objects.
Tests realying on serialized strings
@stof, using __sleep without transient attribute will break serialization for child classes (if parent class has private attributes in the bulk).
In other words: Serializing extended classes won't work anymore.
Real example: I ketp the trasient attribute in the
Here is a list of classes that mention private attributes in
Please, check if I should revert it for some of them.
Here is the list of classes mentioning only protected attributes in
Here is the list of classes I did changed the transient attribute approach:
Tests still failing:
Actually, we cannot do that for
Maybe split the data-collector related changes to a separate PR to move the rest forward?
And we still need to move forward, so we need plans :)
It seems the strategy applyed in
Here is an example where native