Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] do not overwrite the constraint being evaluated #30062

Merged
merged 1 commit into from Feb 7, 2019

Conversation

Projects
None yet
6 participants
@xabbuh
Copy link
Member

commented Feb 2, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27362
License MIT
Doc PR
{
if (!$constraint instanceof Form) {

This comment has been minimized.

Copy link
@xabbuh

xabbuh Feb 2, 2019

Author Member

The $constraint name is also used below when the constraints configured through the constraints option are iterated, but we do not want to overwrite the reference to the constraint that is validated by this constraints.

@HeahDude
Copy link
Member

left a comment

Tricky one, thanks!

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 345a632 into symfony:3.4 Feb 7, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Feb 7, 2019

bug #30062 [Form] do not overwrite the constraint being evaluated (xa…
…bbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[Form] do not overwrite the constraint being evaluated

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27362
| License       | MIT
| Doc PR        |

Commits
-------

345a632 do not overwrite the constraint being evaluated

@xabbuh xabbuh deleted the xabbuh:issue-27362 branch Feb 7, 2019

This was referenced Mar 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.